From 636882316b5191931e144212d93665c10859ac95 Mon Sep 17 00:00:00 2001 From: Steven Le Rouzic Date: Fri, 7 Mar 2025 00:00:43 +0100 Subject: Some work on clang-tidy-ing things up --- asl/strings/string.hpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'asl/strings/string.hpp') diff --git a/asl/strings/string.hpp b/asl/strings/string.hpp index 0f70228..7254762 100644 --- a/asl/strings/string.hpp +++ b/asl/strings/string.hpp @@ -26,7 +26,7 @@ public: constexpr string() requires default_constructible = default; explicit constexpr string(Allocator allocator) : m_buffer{std::move(allocator)} {} - // NOLINTNEXTLINE(*-explicit-conversions) + // NOLINTNEXTLINE(*explicit*) constexpr string(string_view sv) requires default_constructible : m_buffer{sv.as_span()} @@ -44,16 +44,16 @@ public: constexpr string& operator=(const string&) requires copy_assignable = default; constexpr string& operator=(string&&) = default; - constexpr isize_t size() const { return m_buffer.size(); } - constexpr const char* data() const { return m_buffer.data(); } + [[nodiscard]] constexpr isize_t size() const { return m_buffer.size(); } + [[nodiscard]] constexpr const char* data() const { return m_buffer.data(); } - // NOLINTNEXTLINE(*-explicit-conversions) + // NOLINTNEXTLINE(*explicit*) constexpr operator string_view() const { return as_string_view(); } - constexpr string_view as_string_view() const + [[nodiscard]] constexpr string_view as_string_view() const { auto span = m_buffer.as_span(); return string_view{span.data(), span.size()}; -- cgit